Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect order of arguments in IsMouseClicked #7657

Closed
wants to merge 1 commit into from
Closed

Fixed incorrect order of arguments in IsMouseClicked #7657

wants to merge 1 commit into from

Conversation

korenkonder
Copy link
Contributor

Found this bug accidentally. Order of arguments was changed in 85513de but this particular line of code remained the same. This should fix it.

@ocornut
Copy link
Owner

ocornut commented Jun 4, 2024

Thank you! Merged with additional commentary as 209edcc
Broken by 85513de on may 22. This would only affect this IsMouseClicked() signature when passing true.
I will likely tag a release soon to include this.

@ocornut ocornut closed this Jun 4, 2024
@jungnitz
Copy link
Contributor

jungnitz commented Jun 4, 2024

IsKeyChordPressed is equally broken. Funnily enough I found this problem just now as well.

@ocornut ocornut reopened this Jun 4, 2024
jungnitz added a commit to jungnitz/imgui that referenced this pull request Jun 5, 2024
jungnitz added a commit to jungnitz/imgui that referenced this pull request Jun 5, 2024
@jungnitz
Copy link
Contributor

jungnitz commented Jun 5, 2024

Actually, taking another look at it, it doesn't really matter, since ImGuiInputFlags_None is equal to 0 aswell, but it should probably still be corrected. (Sorry for the two commits, accidentally commited into my master first...)

@ocornut
Copy link
Owner

ocornut commented Jun 5, 2024

Thank you, merged as b95b2b4. Indeed it was harmless in this instance.

@ocornut ocornut closed this Jun 5, 2024
@korenkonder korenkonder deleted the patch-1 branch June 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants