Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLBuilder.decodeSegment / DefaultHttpRewriteProvider.rewriteHttp taking much CPU time? #213

Closed
ceefour opened this issue Jun 22, 2015 · 3 comments

Comments

@ceefour
Copy link
Contributor

ceefour commented Jun 22, 2015

I was surprised when I see this in Java Mission Control (see attachment)

download_20150622_133802
Cc @rudiw

@ceefour
Copy link
Contributor Author

ceefour commented Jun 22, 2015

Also with org.ocpsoft.rewrite.servlet.impl.DefaultHttpRewriteProvider.rewriteHttp(HttpServletRewrite)

selection_112

@ceefour ceefour changed the title URLBuilder.decodeSegment taking much CPU time? URLBuilder.decodeSegment / DefaultHttpRewriteProvider.rewriteHttp taking much CPU time? Jun 22, 2015
@chkal
Copy link
Member

chkal commented Jun 25, 2015

Hmmm. AFAIK URLBuilder is deprecated. It still uses java.net.URI for URL decoding. I already reimplemented the decoding in AdressBuilder. Actually we should get rid of URLBuilder in favor of AddressBuilder. But IIRC there were some test failures the last time I tried to remove it.

@lincolnthree
Copy link
Member

Yes, we need to do that, or at least replace the encoding with the encoding provider that AddressBuilder uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants