Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR558 closed w/o comments (Addition of CWE object) #676

Closed
floydtree opened this issue Jun 22, 2023 · 2 comments
Closed

PR558 closed w/o comments (Addition of CWE object) #676

floydtree opened this issue Jun 22, 2023 · 2 comments

Comments

@floydtree
Copy link
Contributor

Noticed a new comment on an older PR which was closed out without a proper reason. Looking at the PR (in brief: add a new CWE object), all the reviewers seem to have agreed to the change.

Does anyone have an insight on why this was closed? If not, are we okay to get those changes in?
@floydtree floydtree changed the title https://github.com/ocsf/ocsf-schema/pull/558 closed w/o comments PR558 closed w/o comments (Addition of CWE object) Jun 22, 2023
@climbertjh2
Copy link

+1 on getting the changes added (if you're looking for votes).

@floydtree
Copy link
Contributor Author

This was discussed in June 27th's weekly call. Will be getting those changes in with a new PR.

@floydtree floydtree mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floydtree @climbertjh2