fix: avoid headers already sent error

octokit · Nov 1, 2018 · db3b1e4 · db3b1e4
1 parent 7a8344c
commit db3b1e4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/proxy.js b/lib/proxy.js
@@ -27,9 +27,11 @@ function proxy (state, { target }) {
     onError (error, request, response) {
       /* istanbul ignore if */
       if (error.message.indexOf('Nock: No match for request') !== 0) {
-        response.writeHead(404, {
-          'Content-Type': 'application/json; charset=utf-8'
-        })
+        if (!response.headerSent) {
+          response.writeHead(500, {
+            'Content-Type': 'application/json; charset=utf-8'
+          })
+        }
 
         return response.end(JSON.stringify({
           error: error.message