-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): actually output ESM #2678
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this when I reviewed your v4 PR, I should have properly tested it 😞
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 3.2.1 | 4.0.2 | ## [v4.0.2](https://github.com/octokit/octokit.js/releases/tag/v4.0.2) ##### Bug Fixes - **build:** actually output ESM ([#2678](octokit/octokit.js#2678)) ([9604674](octokit/octokit.js@9604674)) ## [v4.0.1](https://github.com/octokit/octokit.js/releases/tag/v4.0.1) ##### Bug Fixes - **docs:** remove NodeJS 10 and add callout for conditional exports ([#2675](octokit/octokit.js#2675)) ([c99ff62](octokit/octokit.js@c99ff62)) ## [v4.0.0](https://github.com/octokit/octokit.js/releases/tag/v4.0.0) ##### BREAKING CHANGES - package is now ESM - remove authentication type "oauth" that was previously deprecated - Switch from `@octokit/webhooks-types` to `@octokit/openapi-webhooks-types` due to the transition to using GitHub's OpenAPI schema
Resolves #2676
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!