-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for React Native #273
Comments
In the meantime, there's react-native-github-api, though you'll have to add it manually (pretty sure it's not on npm). |
Here's a more up to date fork, with a single commit to add the RN compatibility: machour@1ef08ec |
I removed the If it still fails, it would be helpful to create a minimal repository that I could use for testing. I’d definitely like to make it work |
Gave it a try in a React Native app by just importing the lib in a screen:
workaround: manually running The culprit seems to be this line: https://github.com/octokit/node-github/blob/master/lib/index.js#L726 RN doesn't seem to have a polyfill for By the way, wasted so much time by testing https://www.npmjs.com/package/node-github instead of https://www.npmjs.com/package/github because of this repo name 😭😭😭😭 |
Thanks for giving it a try!
We will most likely migrate to node-fetch for the browser compatibility
I’m sorry for the trouble :( We will rename this module soon to |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
React Native is a different environment than browser and node. |
Hey I know it's been a while, but I figured folks watching this thread might be interested. The upcoming You can try it out with
|
I attempted to use this package in an application I started building using React Native, unfortunately it did not work.
Requiring the package causes the react packager to hang.
Pressing Command-R in the simulator produces (after about a minute):
The packager hangs forever when attempting to debug.
I am told that not all packages run in React Native, mainly ones that designed specifically for Node JS (express for example).
The text was updated successfully, but these errors were encountered: