Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #241

Closed
5 tasks
first-timers bot opened this issue Oct 15, 2020 · 3 comments
Closed
5 tasks

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #241

first-timers bot opened this issue Oct 15, 2020 · 3 comments

Comments

@first-timers
Copy link

first-timers bot commented Oct 15, 2020

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

The Pika CDN is now Skypack, see https://www.pika.dev/cdn. The CDN at https://cdn.pika.dev/ no longer works, all URLs must be replaced with the new CDN: https://cdn.skypack.dev/. We currently recommend using cdn.pika.dev to import the library into the browser, but that no longer works. Replacing it with cdn.skypack.dev will make it work again.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    More than one person can work on this issue, don't worry if it's already claimed.

  • πŸ“ Update the file \README.md (press the little pen Icon) and edit as shown below:

@@ -15,12 +15,12 @@
 Browsers
 </th><td width=100%>
 
-Load `@octokit/plugin-enterprise-cloud` and [`@octokit/core`](https://github.com/octokit/core.js) (or core-compatible module) directly from [cdn.pika.dev](https://cdn.pika.dev)
+Load `@octokit/plugin-enterprise-cloud` and [`@octokit/core`](https://github.com/octokit/core.js) (or core-compatible module) directly from [cdn.skypack.dev](https://cdn.skypack.dev)
 
 ```html
 <script type="module">
-  import { Octokit } from "https://cdn.pika.dev/@octokit/core";
-  import { enterpriseCloud } from "https://cdn.pika.dev/@octokit/plugin-enterprise-cloud";
+  import { Octokit } from "https://cdn.skypack.dev/@octokit/core";
+  import { enterpriseCloud } from "https://cdn.skypack.dev/@octokit/plugin-enterprise-cloud";
 </script>
 ```
 
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

    1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
    2. You can edit files directly in your browser
  • 🏁 Done Ask for a review :)

If there are more than one pull requests with the correct change, we will merge the first one, but attribute the change to all authors who made the same change using @Co-authored-by, so yo can be sure your contribution will count.

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@mingweisoo
Copy link

Could I work on this?

@gr2m
Copy link
Contributor

gr2m commented Oct 25, 2020

@evansusu see my comment here octokit/plugin-rest-endpoint-methods.js#245 (comment)

@gr2m gr2m removed their assignment Oct 25, 2020
@gr2m gr2m closed this as completed in 682729b Nov 1, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

πŸŽ‰ This issue has been resolved in version 5.0.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants