Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: machine-man preview graduated #185

Merged
merged 10 commits into from
Sep 3, 2020
Merged

fix: machine-man preview graduated #185

merged 10 commits into from
Sep 3, 2020

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first, then update the @octokit/types version in package.json in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the new endpoints introduced in 007418b?file-filters%5B%5D=.ts are incorrect, they are all for GitHub Enterprise Cloud only

Update: that should be fixed via d00cf03

@gr2m gr2m self-assigned this Aug 9, 2020
@gr2m gr2m added blocked Type: Feature New feature or request labels Aug 9, 2020
gr2m
gr2m previously approved these changes Sep 3, 2020
@gr2m gr2m changed the title 🚧 GitHub OpenAPI specifications changed fix: machine-man preview graduated Sep 3, 2020
@gr2m gr2m merged commit 34559d8 into master Sep 3, 2020
@gr2m gr2m deleted the openapi-update branch September 3, 2020 19:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2020

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants