Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited readme.md #257

Closed
wants to merge 3 commits into from
Closed

edited readme.md #257

wants to merge 3 commits into from

Conversation

mingweisoo
Copy link

No description provided.

@mingweisoo
Copy link
Author

Help guys! I have no idea what is happening!

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You nearly got it. Sorry that our code formatter CI is so particular, it helps to keep our code base consistent despite having many contirbutors

README.md Outdated Show resolved Hide resolved
@gr2m gr2m linked an issue Oct 25, 2020 that may be closed by this pull request
5 tasks
@gr2m gr2m added Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation labels Oct 25, 2020
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now, yay! We will merge your changes shortly, together with other pull requests that address the same issue. We also added the hacktoberfest-accepted label so your pull request counts already, in case you are participating.

@gr2m
Copy link
Contributor

gr2m commented Nov 1, 2020

Congratulations 🥳 We hope you enjoyed the process of sending the pull requests, and maybe learned a thing or two? If anything was unclear, or if you have any suggestions on how we can improve the suggestions in the issue #123, please let us know! It will help future first time contributors!

If you are looking to make another pull requests, look out for issues with the help wanted label. They are not as straight forward as the first-timers-only issues, but hey, you no longer are a first-timers 🙂 You can find help wanted issues here.

You can help us by starring this repository, as well as our primary repository at https://github.com/octokit/rest.js/ ⭐️ Stars help others to discover our project.

If you are interested in Octokit and future opportunities to contribute, you can subscribe to our announcement discussion at https://github.com/octokit/rest.js/discussions/620. We will post and update soon and will point out issues you can contribute to.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

🎉 This issue has been resolved in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README
2 participants