Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Peer dependency of @octokit/core@">=5" broken as @octokit/core@6 is ESM #717

Closed
1 task done
DanCurryy opened this issue Feb 26, 2024 · 2 comments
Closed
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@DanCurryy
Copy link

DanCurryy commented Feb 26, 2024

What happened?

Now that octokitcore@6 has moved to ESM the peer dependency usage results in problems when attempting to load the module. This is affecting versions of this plugin before it moved to ESM

Versions

Octokit/[email protected], Node 18.19.0

Relevant log output

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in ...../node_modules/@octokit/core/package.json
    at new NodeError (node:internal/errors:405:5)
    at exportsNotFound (node:internal/modules/esm/resolve:366:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:656:13)
    at resolveExports (node:internal/modules/cjs/loader:584:36)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@DanCurryy DanCurryy added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 26, 2024
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Feel free to submit a PR for the 10.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

No branches or pull requests

2 participants