-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
potential bug: native fetch not throwing errors? #699
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Is your code using vanilla is it for an installation access token? I think |
I use probot. Maybe something wrong with google cloud functions framework. |
Somewhere in our code, it seems that the status code of the Response object is a string! Atleast when we use GCF. Very strange |
maybe GCF middleware is doing something weird? |
I focus on improving probot and octokit. maybe then I figure out where the issue is. |
I have a bug in the production where a 404 response is not throwing accordingly.
Very strange behaviour. For this I am currently proposing PRs which make it easier for me to investigate the bug. I have the strong feeling that there is a bug in this repo, and it is not showing properly because we mock the fetch calls.
The text was updated successfully, but these errors were encountered: