Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use test_matrix and test jobs #163

Closed
wolfy1339 opened this issue Jul 8, 2022 · 0 comments · Fixed by #168
Closed

ci: use test_matrix and test jobs #163

wolfy1339 opened this issue Jul 8, 2022 · 0 comments · Fixed by #168
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@wolfy1339
Copy link
Member

Follow up to #157
Ideally we would do a test_matrix step and then a test step that depends on test_matrix, so that for branch protections we can require test independent of the Node versions we are using.

See this for reference: https://github.com/octokit/core.js/blob/393caf31b2e802ea9be59aa84f90d64f98953fdb/.github/workflows/test.yml#L32
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 8, 2022
@wolfy1339 wolfy1339 linked a pull request Jul 11, 2022 that will close this issue
ci(test): use test_matrix and test jobs #168
Merged
@jeffwilcox jeffwilcox mentioned this issue Sep 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test): use test_matrix and test jobs octokit/rest.js
1 participant
@wolfy1339