-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use daemonset way not sidecar way #9
Comments
Sounds like a really interesting feature @withlin
I think changing the behavior to this will allow us to both remove the |
if you scan all processes, may be have problem. for instance: i want to collect specific process,such as only collect voting service data. hi @edeNFed , i have a idea as follow:
|
That sounds really cool. I wonder if we should integrate somehow with the OpenTelemetry Operator: https://github.com/open-telemetry/opentelemetry-operator#opentelemetry-auto-instrumentation-injection It looks like they are doing similar things, for example, annotating deployments for instrumentation. |
@edeNFed Yes, this project that sound good to me.opentelemetry-auto-instrumentation-injection is using mutating webhook intercept by annotation(inject container in pod resource). https://github.com/open-telemetry/opentelemetry-operator/blob/main/internal/webhookhandler/webhookhandler.go#L92 before you send to me for this project,i have no idea for it. use daemonset way may reduce overhead vs sidecar,that's why I recommend implementing this way. |
@withlin After reading your comments again, I think I understand what you mean much better now. Another thing we probably need to implement as part of this is how to stop instrumenting when the annotation is deleted, It should probably delete all the attached uprobes. I like it. Would you like to try to implement it? I can also get to it in about two weeks. |
@edeNFed i am glading to implement it. but i need some time to familiar with your source code. |
Feature request
use daemonset way not sidecar way
Use case
May be consider daemonset that it will deploy agent on nodes,which it will collect data by pid, and the use pid association with pod metadata.
what do you think? @edeNFed
The text was updated successfully, but these errors were encountered: