Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenLineage FVT fails with gremlin 3.5.2->3.6.0 update #6602

Closed
planetf1 opened this issue Jun 1, 2022 · 7 comments
Closed

OpenLineage FVT fails with gremlin 3.5.2->3.6.0 update #6602

planetf1 opened this issue Jun 1, 2022 · 7 comments
Assignees
Labels
external-dependency Related to an external dependency (ie maven package etc). Bug or update no-issue-activity Issues automatically marked as stale because they have not had recent activity.

Comments

@planetf1
Copy link
Member

planetf1 commented Jun 1, 2022

When testing this month's updates, the lineage FVT fails in gradle with:

LineageGraphQueryServiceTest STANDARD_OUT
    11:38:02.471 [Test worker] INFO  o.j.d.c.b.ReadConfigurationBuilder - Set default timestamp provider MICRO
    11:38:02.507 [Test worker] INFO  o.j.g.i.UniqueInstanceIdRetriever - Generated unique-instance-id=7f00000132744-egeriadevrhel1
    11:38:02.533 [Test worker] INFO  o.j.d.c.ExecutorServiceBuilder - Initiated fixed thread pool of size 8
    11:38:02.669 [Test worker] INFO  o.j.diskstorage.log.kcvs.KCVSLog - Loaded unidentified ReadMarker start time 2022-06-01T10:38:02.669024Z into org.janusgraph.diskstorage.log.kcvs.KCVSLog$MessagePuller@e5c5e6

LineageGraphQueryServiceTest > initializationError FAILED
    java.lang.NoSuchMethodError: 'org.apache.tinkerpop.gremlin.structure.util.CloseableIterator org.apache.tinkerpop.gremlin.structure.util.CloseableIterator.asCloseable(java.util.Iterator)'
        at org.janusgraph.graphdb.util.CloseableIteratorUtils.<clinit>(CloseableIteratorUtils.java:28)
        at org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.lambda$iterables$1(GraphCentricQueryBuilder.java:239)
        at com.google.common.collect.Iterables.getOnlyElement(Iterables.java:278)
        at org.janusgraph.graphdb.database.StandardJanusGraph$1.retrieveSchemaByName(StandardJanusGraph.java:426)
        at org.janusgraph.graphdb.database.cache.StandardSchemaCache.getSchemaId(StandardSchemaCache.java:111)
        at org.janusgraph.graphdb.transaction.StandardJanusGraphTx.getSchemaVertex(StandardJanusGraphTx.java:1033)
        at org.janusgraph.graphdb.transaction.StandardJanusGraphTx.getVertexLabel(StandardJanusGraphTx.java:1168)
        at org.janusgraph.graphdb.database.management.ManagementSystem.getVertexLabel(ManagementSystem.java:1508)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.factory.OpenLineageSchemaHelper.checkAndAddLabelVertex(OpenLineageSchemaHelper.java:98)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.factory.OpenLineageSchemaHelper.createSchemas(OpenLineageSchemaHelper.java:73)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.factory.GraphFactory.initializeGraph(GraphFactory.java:131)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.factory.GraphFactory.openEmbeddedGraph(GraphFactory.java:79)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.factory.GraphFactory.openGraph(GraphFactory.java:52)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.graph.GraphHelper.openGraph(GraphHelper.java:41)
        at org.odpi.openmetadata.openconnectors.governancedaemonconnectors.openlineageconnectors.janusconnector.lineagegraph.LineageGraphQueryServiceTest.beforeClass(LineageGraphQueryServiceTest.java:60)

Gradle Test Executor 251 finished executing tests.

Likely similar in maven.

Looks like some API changes relating to java.lang.NoSuchMethodError: 'org.apache.tinkerpop.gremlin.structure.util.CloseableIterator

This also fails with janus ( JanusGraph/janusgraph#3037 ) though it may be the next version addresses, so worth considering. May also be a repackaging issue

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Aug 10, 2022
@planetf1
Copy link
Member Author

this still occurs

@planetf1 planetf1 removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Aug 10, 2022
@planetf1 planetf1 added the external-dependency Related to an external dependency (ie maven package etc). Bug or update label Sep 30, 2022
@lpalashevski
Copy link
Contributor

lpalashevski commented Nov 10, 2022

The fix was merged to master some time ago. This is the PR JanusGraph/janusgraph#3208
We are going to update and re-test once the next release is out.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jan 10, 2023
@planetf1 planetf1 removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jan 10, 2023
@planetf1
Copy link
Member Author

planetf1 commented Feb 1, 2023

Janusgraph is at version 1.0 RC.
Dependabot recommended an update, but I will close dependabot update & suggest we continue monitoring until v1 is finally released. This will likely co-incide with version 4.x of egeria.

See

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Apr 3, 2023
@lpalashevski lpalashevski removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jun 3, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dependency Related to an external dependency (ie maven package etc). Bug or update no-issue-activity Issues automatically marked as stale because they have not had recent activity.
Projects
No open projects
Development

No branches or pull requests

4 participants