Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candy Oven in Celsius #193

Open
nitaybz opened this issue Oct 19, 2022 · 1 comment
Open

Candy Oven in Celsius #193

nitaybz opened this issue Oct 19, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@nitaybz
Copy link

nitaybz commented Oct 19, 2022

Hi,
Thanks for creating this plugin 🙏🏼.

I tried the plugin with my Candy oven and noticed that the plugin is showing wrong temperature value, after investigating a little bit in the code I found out that you are using Fahrenheit to Celsius function which is completely unnecessary for me, I tried to create the request to the oven and saw that it gets the temperature already in Celsius but it needs to be devided by 10.

So I'm getting from the request 2200 for 220 degrees Celsius.

Hope you can make the proper adjustments to make it work.
Thanks again :)

@ofalvai
Copy link
Owner

ofalvai commented Nov 19, 2022

That is a tough problem because some devices report the value in Fahrenheit and we have no way to tell which device reports in which format.

My first idea was to look at the number itself and if it's above a threshold (say 600), then it must be in Celsius * 10, else in Fahrenheit. But this wouldn't work with low temperatures reported as Celsius * 10, such as 40 degrees, reported as 400. This value could also mean a valid oven temperature in Fahrenheit (400F = 204C).

I'll leave this issue open, maybe someone has a better idea of how to parse the reported value without breaking any of the appliances.

@ofalvai ofalvai added the help wanted Extra attention is needed label Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants