export hasValidations decorator for es6 style models #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ember-beta has a bug that prevents build from succeeding when trying to test against it, so i put that in the tests that were allowed to fail. This setting makes sense anyway .. because beta and canary are not usually stable, and to require them to pass for CI to pass seems a bit unreasonable. |
|
@danielspaniel this is awesome! Thanks for taking the time to get this done. |
|
your welcome @offirgolan .. i am surprised no one did this before because you kinda need this if you make models in class based style |
|
They probably have but you're the only one to open a PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #556
Changes proposed:
hasValidationsclass level decorator which allows you to add validations to an es6 style ember data model or componentTasks: