Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter 5 infinite loop #1

Open
okaneco opened this issue Oct 23, 2020 · 0 comments
Open

Filter 5 infinite loop #1

okaneco opened this issue Oct 23, 2020 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@okaneco
Copy link
Owner

okaneco commented Oct 23, 2020

After a few temperature drops, the visit queue doesn't empty when running with filter size 5. There's a step counter and a debug print!() that can be uncommented to monitor the length. The black to white gradient that's 135x135 converges depending on the rng seed, and I've had the rainbow gradient converge as well. From watching the queue lengths that print out, it seems like the rng may stop adequately shuffling since it gets called so many times. The while loop clears out the queue length when it gets too large but the queue never seems to empty. I've gone over the code many times comparing it to the original and nothing obvious stood out but I assume the bug is in my implementation. I tried chacha and hc but those had the same issue. I'm not sure what criteria to use to reseed the rng or if that would even help.

step counter

// let mut steps = 0u32;

visit_queue
while !visit_queue.is_empty() {

print debug

rscolorq/src/quant.rs

Lines 458 to 462 in ce42053

// steps += 1;
// if steps % 10_000 == 0 {
// print!("{},", visit_queue.len());
// std::io::Write::flush(&mut std::io::stdout()).unwrap();
// }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant