Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raw buffer constructor example #567

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Fix raw buffer constructor example #567

merged 1 commit into from
Aug 25, 2018

Conversation

d07RiV
Copy link
Contributor

@d07RiV d07RiV commented Aug 25, 2018 •
edited by hipstersmoothie
Loading

What's Changing and Why

Constructor expects data, not buffer field. The example provided fails with

No matching constructor overloading was found.
Please see the docs for how to call the Jimp constructor.

What else might be affected

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

closes #565

@d07RiV d07RiV mentioned this pull request Aug 25, 2018
Closed
@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Aug 25, 2018
@hipstersmoothie hipstersmoothie merged commit d7ca5d1 into jimp-dev:master Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug there is a bug in the way jimp behaves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong documentation for buffer constructor.
2 participants
@d07RiV @hipstersmoothie