Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print #572

Merged
merged 6 commits into from
Sep 1, 2018
Merged

Print #572

merged 6 commits into from
Sep 1, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What's Changing and Why

Expose final y value in print callback so users can easily stagger text

closes #506

What else might be affected

nothing

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie hipstersmoothie added the enhancement a request for a new feature or change in behavior label Aug 27, 2018
@edi9999
Copy link
Contributor

edi9999 commented Aug 27, 2018

If we expose the y value, we might as well expose the x value to have the full coordinate of the last letter, no ?

@edi9999
Copy link
Contributor

edi9999 commented Aug 27, 2018

If you think the same, I would prefer to expose an object with both values :

coordinate = {x: x, y: y}

@hipstersmoothie
Copy link
Collaborator Author

@edi9999 comments addressed. Added the x value as well

edi9999
edi9999 reviewed Aug 29, 2018
View reviewed changes
packages/jimp/README.md Outdated
10,
'Hello world that wraps!',
50,
(err, image, yValue) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample needs to be changed with x/y value

@hipstersmoothie hipstersmoothie merged commit 4250a7a into master Sep 1, 2018
hipstersmoothie added a commit that referenced this pull request Sep 1, 2018
@hipstersmoothie
Print (#572)
61c5e2a 
* fix cb with no maxheight and expose y value in callback

* test y value spacing

* update image callback

* add to readme

* code review

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edi9999 edi9999 edi9999 left review comments

Assignees

@edi9999 edi9999

Labels
enhancement a request for a new feature or change in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose y position in print callback
2 participants
@hipstersmoothie @edi9999