Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG Thinq HA Core integration #817

Open
rrooggiieerr opened this issue Oct 20, 2024 · 12 comments
Open

LG Thinq HA Core integration #817

rrooggiieerr opened this issue Oct 20, 2024 · 12 comments
Labels
documentation Improvements or additions to documentation

Comments

@rrooggiieerr
Copy link

Just FYI, there seems to be a LG Thinq HA Core integration in the making

https://github.com/home-assistant/core/tree/lg_thinq/homeassistant/components/lg_thinq
https://github.com/home-assistant/home-assistant.io/blob/lg_thinq/source/_integrations/lg_thinq.markdown

It uses this library
https://github.com/thinq-connect/pythinqconnect

And an official API
https://thinq.developer.lge.com/en/cloud/

@ollo69
Copy link
Owner

ollo69 commented Oct 20, 2024

Interesting, so I suppose that when ready will replace this integration.
I will take a look, thanks for informing.

@ollo69 ollo69 pinned this issue Oct 21, 2024
@ollo69 ollo69 added the documentation Improvements or additions to documentation label Oct 21, 2024
@w-marco
Copy link

w-marco commented Oct 24, 2024

Fwiw I loaded it in as a custom component today to play around and especially for dryers and washers it's still really barebones, though we can't know at which state they will release it. But at least for quite a while I can't imagine that it can fully replace this integration.

But maybe it could serve either as inspiration or work from this integration could be merged into core. Or they could just co-exist (see Nuki Core and Nuki-Ng custom_component both living in co-existence).

Maybe the auth via Personal Access Token instead of User/Password would be interesting for this integration?

@felipecrs
Copy link

It should be released to stable in HA 2024.11.0 btw.

@felipecrs
Copy link

It's crazy to see the lot of work spent here just being redone, but I believe this integration is being sponsored by LG. I don't know why the user would be named that way otherwise.

image

@rrooggiieerr
Copy link
Author

It should be released to stable in HA 2024.11.0

I saw that too.

It's crazy to see the lot of work spent here just being redone

Exactly my thoughts, they could at least have contacted the developer for collaboration. Having said that, they seem to have developed a decent API and library with push updates using mqtt instead of polling.

@ollo69
Copy link
Owner

ollo69 commented Oct 31, 2024

Exactly my thoughts, they could at least have contacted the developer for collaboration

Yes, it would have been nice. But I like to think that all the work done here has at least been inspiring. I am always available to collaborate with HA team if necessary.

@crazyserver
Copy link

I don't like when this kind of things happen, Open source is our power!

However I want to share that the new official integration completely integrates vacuum cleaners! I'm very happy to see that!

Thanks @ollo69 for all your time dedicated to this project and other projects!

@NewsGuyTor
Copy link

This is both weird and cool. It is clearly being developed by LG itself (most commits are co-authored by two Korean persons with [email protected] emails). That is pretty cool by itself, when big brands like LG invest in HA integrations it's a pretty promising sign for the future of HA.

On the other hand it is quite weird that @ollo69 hasn't been told about it/consulted at all.

Anyway, thanks for all your work @ollo69! It's gotta be both weird and inspiring to see a big brand like LG realize the value of your work so much that they decide to invest company resources into developing their own official integration, yet perhaps also slightly melancholic.

@w-marco
Copy link

w-marco commented Oct 31, 2024

That said, if they don't add a big commit in this or next release, the integration still vastly lacks behind this one.

I have a dozen sensors and full control over remote start for my washer with this custom integration while the official one still has barely any sensors, does not support setting temperature and such (whereas there's a working PR here that does) and so on. So for the foreseeable future I can't see myself switching.

@bschatzow
Copy link

The core version in beta only has 9 sensors vs this one that has 28 for my washer.

@bschatzow
Copy link

bschatzow commented Nov 1, 2024

Exactly my thoughts, they could at least have contacted the developer for collaboration

Yes, it would have been nice. But I like to think that all the work done here has at least been inspiring. I am always available to collaborate with HA team if necessary.

I have raised an issue with the new built in one in the beta discord channel. The new integration is missing many useful sensors.

@NukeThemTillTheyGlow
Copy link

I'm on version 0.40.3 and through various updates a few of the sensors are no longer displaying properly and before trying to update and fix things, I was wondering should I just delete the current integration and switch to the new? I installed manually about 9 months ago, its just for a washer and dryer. Only really use it for status checking, when things are done, but I also like to be on a fully maintained version too. Any advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

8 participants