Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master fails to build #28

Closed
virtualritz opened this issue Jun 30, 2019 · 2 comments
Closed

Master fails to build #28

virtualritz opened this issue Jun 30, 2019 · 2 comments

Comments

@virtualritz
Copy link

error[E0432]: unresolved import `plexus::encoding::ply`
  --> examples/viewer/main.rs:14:23
   |
14 | use plexus::encoding::ply::PointEncoding;
   |                       ^^^ could not find `ply` in `encoding`

warning: unused import: `plexus::prelude::*`
  --> examples/viewer/main.rs:16:5
   |
16 | use plexus::prelude::*;
   |     ^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

error[E0599]: no function or associated item named `from_ply` found for type `plexus::graph::MeshGraph<Geometry>` in the current scope
  --> examples/viewer/main.rs:66:36
   |
66 |             MeshGraph::<Geometry>::from_ply(PointEncoding::<Point3<f32>>::default(), ply)
   |                                    ^^^^^^^^ function or associated item not found in `plexus::graph::MeshGraph<Geometry>`

error: aborting due to 2 previous errors
@olson-sean-k
Copy link
Owner

olson-sean-k commented Jul 1, 2019

I'm guessing this is the output from cargo test. Cargo does not support specifying feature flags required for examples and the viewer example now uses the encoding-ply feature. To work around this, use cargo test --all-features instead (and consider enabling encoding-ply in the dependency specification for Plexus). Please let me know if cargo build is failing for you; AFAICT, it is currently succeeding on master.

This is what the recent viewer branch is attempting to fix: it moves the code from the viewer example into a package so that it can be shared by examples for rendering and take a dependency on Plexus with the necessary features. Cargo uses a similar approach itself.

@olson-sean-k
Copy link
Owner

This should be fixed by 9d898a4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants