Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain dtypes & shape for multiscale arrays #2

Open
joshmoore opened this issue Nov 23, 2020 · 4 comments · May be fixed by #154
Open

Constrain dtypes & shape for multiscale arrays #2

joshmoore opened this issue Nov 23, 2020 · 4 comments · May be fixed by #154

Comments

@joshmoore
Copy link
Member

see: tischi/i2k-2020-s3-zarr-workshop#9 (comment)

The current spec allows for each resolution level to be a different dtype. This should be restricted with a clause that they "MUST be the same".
@constantinpape
Copy link
Contributor

I think this is still relevant

@constantinpape constantinpape mentioned this issue Feb 2, 2022
Open
13 tasks
@will-moore
Copy link
Member

I was wondering today whether the number of dims len(shape) MUST be the same for each resolution level?
I assume this is the case but I didn't see anything in the spec?

@joshmoore joshmoore changed the title Constrain dtypes for multiscale arrays Constrain dtypes & shape for multiscale arrays Feb 3, 2022
@joshmoore
Copy link
Member Author

👍 for both constraints (title of issue updated)

@constantinpape constantinpape mentioned this issue Feb 16, 2022
Open
9 tasks
@joshmoore joshmoore mentioned this issue Feb 25, 2022
Open
2 tasks
@constantinpape constantinpape mentioned this issue Jul 29, 2022
Closed
@will-moore
Copy link
Member

@constantinpape Please go ahead and open a PR against the spec to state that dytpes must be the same for each Dataset resolution.
You might get conflicts with other PRs (e.g. #138 changes quite a lot) but at least this will push this change forward and check there are no objections etc.

@will-moore will-moore mentioned this issue Oct 21, 2022
Closed
constantinpape added a commit that referenced this issue Oct 21, 2022
@constantinpape
Update index.bs
2f74b57 
Fixes #2
@constantinpape constantinpape linked a pull request Oct 21, 2022 that will close this issue
Open
@constantinpape constantinpape mentioned this issue Nov 26, 2023
Open
yarikoptic added a commit to yarikoptic/ngff that referenced this issue Sep 11, 2024
@yarikoptic
Add my re-review (ome#2) of RFC-2
5c25ae7
joshmoore added a commit to joshmoore/ngff that referenced this issue Sep 12, 2024
@joshmoore
Merge pull request #1 from yarikoptic/rfc-2-updates
9f14407 
Add my re-review (ome#2) of RFC-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require same datatype for all arrays in multiscales:datasets ome/ngff
3 participants
@joshmoore @will-moore @constantinpape