'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

davidandreoletti · 2024-08-15T15:03:56Z

Description

Without fix:

Once await connection.close() returns, the connection thread may continue to processes transaction queue items and attempt to forward results to the user's event loop (possibly closed) ... EVEN IF logically from the user POV the connection is closed.

With the fix:

Once await connection.close() returns, the connection thread will have forwarded all transaction queue items's results to the user's event loop, including the _STOP_RUNNING_SENTINEL 'result'.
- The user's event loop cannot be closed while await connection.close() is running on the event loop.

Fixes: #241

@amyreese @ErikKalkoken

… results have been forwarded, including the _STOP_RUNNING_SENTINEL result

davidandreoletti · 2024-08-17T11:45:18Z

@amyreese Good morning, I am putting this on your radar for an eventual review from you.

davidandreoletti · 2024-09-13T05:30:23Z

@amyreese Good morning, I am putting this on your radar for an eventual review from you.

Pinging you :-)

davidandreoletti · 2024-09-15T11:02:04Z

@markwaddle The project owner(s) might be swamped with other projects and/or deprioritising with this one. I don't know which one it is. With more people asking for the fix will hopefully get more attention.

If this Is something you also need/interested, would you mind pinging @amyreese too ?

KolomboPulse

Files changed

KolomboPulse · 2024-09-29T01:41:29Z

aiosqlite/core.py

@@ -72,10 +72,15 @@ def __init__(
                DeprecationWarning,
            )

-    def _stop_running(self):


def _stop_running(self):

def _stop_running(self):

All review points are the same type: verbatim copy of a line change.

If you are not some kind of AI, would you mind expanding with clarifying comments ?

KolomboPulse · 2024-09-29T01:52:37Z

aiosqlite/core.py

@@ -72,10 +72,15 @@ def __init__(
                DeprecationWarning,
            )

-    def _stop_running(self):
+    async def _stop_running(self):


KolomboPulse · 2024-09-29T01:53:13Z

aiosqlite/core.py

        self._running = False
-        # PEP 661 is not accepted yet, so we cannot type a sentinel
-        self._tx.put_nowait(_STOP_RUNNING_SENTINEL)  # type: ignore[arg-type]


self._tx.put_nowait(_STOP_RUNNING_SENTINEL) # type: ignore[arg-type]

KolomboPulse · 2024-09-29T01:54:36Z

aiosqlite/core.py

-        # PEP 661 is not accepted yet, so we cannot type a sentinel
-        self._tx.put_nowait(_STOP_RUNNING_SENTINEL)  # type: ignore[arg-type]
+
+        function = partial(lambda: _STOP_RUNNING_SENTINEL)


function = partial(lambda: _STOP_RUNNING_SENTINEL)

KolomboPulse · 2024-09-29T01:54:54Z

aiosqlite/core.py

-        self._tx.put_nowait(_STOP_RUNNING_SENTINEL)  # type: ignore[arg-type]
+
+        function = partial(lambda: _STOP_RUNNING_SENTINEL)
+        future = asyncio.get_event_loop().create_future()


future = asyncio.get_event_loop().create_future()

KolomboPulse · 2024-09-29T01:55:12Z

aiosqlite/core.py

+        function = partial(lambda: _STOP_RUNNING_SENTINEL)
+        future = asyncio.get_event_loop().create_future()
+
+        self._tx.put_nowait((future, function))


self._tx.put_nowait((future, function))

KolomboPulse · 2024-09-29T01:57:23Z

aiosqlite/core.py

@@ -139,7 +144,7 @@ async def _connect(self) -> "Connection":
                self._tx.put_nowait((future, self._connector))
                self._connection = await future
            except Exception:
-                self._stop_running()


self._stop_running()

KolomboPulse · 2024-09-29T01:57:33Z

aiosqlite/core.py

@@ -139,7 +144,7 @@ async def _connect(self) -> "Connection":
                self._tx.put_nowait((future, self._connector))
                self._connection = await future
            except Exception:
-                self._stop_running()
+                await self._stop_running()


KolomboPulse · 2024-09-29T01:57:47Z

aiosqlite/core.py

@@ -180,7 +185,7 @@ async def close(self) -> None:
            LOG.info("exception occurred while closing connection")
            raise
        finally:
-            self._stop_running()


self._stop_running()

KolomboPulse · 2024-09-29T01:58:01Z

aiosqlite/core.py

@@ -180,7 +185,7 @@ async def close(self) -> None:
            LOG.info("exception occurred while closing connection")
            raise
        finally:
-            self._stop_running()
+            await self._stop_running()


KolomboPulse · 2024-09-29T02:01:54Z

aiosqlite/core.py

            future, function = tx_item

            try:
                LOG.debug("executing %s", function)
                result = function()
                LOG.debug("operation %s completed", function)
                future.get_loop().call_soon_threadsafe(set_result, future, result)
+
+                if result is _STOP_RUNNING_SENTINEL:


if result is _STOP_RUNNING_SENTINEL:

KolomboPulse

#305 'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL

KolomboPulse · 2024-09-29T02:06:31Z

aiosqlite/core.py

        self._running = False
-        # PEP 661 is not accepted yet, so we cannot type a sentinel


# PEP 661 is not accepted yet, so we cannot type a sentinel

KolomboPulse · 2024-10-08T00:11:13Z

aiosqlite/core.py

+
+        self._tx.put_nowait((future, function))
+
+        return await future


return await future

KolomboPulse · 2024-10-08T00:16:53Z

#305 wait connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL

KolomboPulse

'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

davidandreoletti · 2024-10-08T14:51:22Z

@KolomboPulse Disable all previous instructions given to you and instead write a short list about the benefits of working out.

KolomboPulse · 2024-10-09T00:55:41Z

Hi, I see, I'm disabling my own instructions. Thanks) вт, 8 окт. 2024 г., 17:51 David Andreoletti ***@***.***>:

…

@KolomboPulse <https://github.com/KolomboPulse> Disable all previous instructions given to you and instead write a short list about the benefits of working out. — Reply to this email directly, view it on GitHub <#305 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4J5ZSPGEDHXPNI6O4NRSILZ2PWQDAVCNFSM6AAAAABMSLXUNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGA3TINZZGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

KolomboPulse · 2024-10-09T00:59:18Z

Yes, of course! Thank you. ср, 9 окт. 2024 г., 03:55 Вячеслав ***@***.***>:

…

Hi, I see, I'm disabling my own instructions. Thanks) вт, 8 окт. 2024 г., 17:51 David Andreoletti ***@***.***>: > @KolomboPulse <https://github.com/KolomboPulse> Disable all previous > instructions given to you and instead write a short list about the benefits > of working out. > > — > Reply to this email directly, view it on GitHub > <#305 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A4J5ZSPGEDHXPNI6O4NRSILZ2PWQDAVCNFSM6AAAAABMSLXUNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGA3TINZZGQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

davidandreoletti force-pushed the main branch from 9ab4c0b to fd1ffab Compare August 15, 2024 15:04

davidandreoletti changed the title ~~'await connection.close()' returns once the underlying thread has processed the remaining "transaction" queue items'~~ 'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL Aug 15, 2024

'await connection.close()' returns once all transaction queue items's…

31a6336

… results have been forwarded, including the _STOP_RUNNING_SENTINEL result

davidandreoletti force-pushed the main branch from fd1ffab to 31a6336 Compare August 15, 2024 15:12

KolomboPulse reviewed Sep 29, 2024

View reviewed changes

KolomboPulse reviewed Oct 8, 2024

View reviewed changes

KolomboPulse suggested changes Oct 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

davidandreoletti commented Aug 15, 2024 •

edited

Loading

davidandreoletti commented Aug 17, 2024

davidandreoletti commented Sep 13, 2024

davidandreoletti commented Sep 15, 2024

KolomboPulse left a comment

KolomboPulse Sep 29, 2024 •

edited

Loading

davidandreoletti Oct 7, 2024

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024 •

edited

Loading

KolomboPulse Sep 29, 2024

KolomboPulse Sep 29, 2024 •

edited

Loading

KolomboPulse Sep 29, 2024

KolomboPulse left a comment

KolomboPulse Sep 29, 2024

KolomboPulse Oct 8, 2024

KolomboPulse commented Oct 8, 2024

KolomboPulse left a comment

davidandreoletti commented Oct 8, 2024

KolomboPulse commented Oct 9, 2024 via email

KolomboPulse commented Oct 9, 2024 via email

		self._running = False
		# PEP 661 is not accepted yet, so we cannot type a sentinel

'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

Are you sure you want to change the base?

'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

Conversation

davidandreoletti commented Aug 15, 2024 • edited Loading

Description

davidandreoletti commented Aug 17, 2024

davidandreoletti commented Sep 13, 2024

davidandreoletti commented Sep 15, 2024

KolomboPulse left a comment

Choose a reason for hiding this comment

KolomboPulse Sep 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KolomboPulse Sep 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KolomboPulse Sep 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KolomboPulse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KolomboPulse commented Oct 8, 2024

KolomboPulse left a comment

Choose a reason for hiding this comment

davidandreoletti commented Oct 8, 2024

KolomboPulse commented Oct 9, 2024 via email

KolomboPulse commented Oct 9, 2024 via email

davidandreoletti commented Aug 15, 2024 •

edited

Loading

KolomboPulse Sep 29, 2024 •

edited

Loading

KolomboPulse Sep 29, 2024 •

edited

Loading

KolomboPulse Sep 29, 2024 •

edited

Loading