From 133dc0e8643e9ba467121163272f1b8b04c203ef Mon Sep 17 00:00:00 2001 From: Kelvin Muchiri Date: Wed, 19 Jul 2023 20:54:23 +0300 Subject: [PATCH] refactor code --- ...sx => childrens_survey_sw_missing_en_label.xlsx} | Bin onadata/libs/tests/utils/test_export_builder.py | 6 ++++-- 2 files changed, 4 insertions(+), 2 deletions(-) rename onadata/apps/logger/tests/fixtures/{childrens_survey_sw_missing_lang_label.xlsx => childrens_survey_sw_missing_en_label.xlsx} (100%) diff --git a/onadata/apps/logger/tests/fixtures/childrens_survey_sw_missing_lang_label.xlsx b/onadata/apps/logger/tests/fixtures/childrens_survey_sw_missing_en_label.xlsx similarity index 100% rename from onadata/apps/logger/tests/fixtures/childrens_survey_sw_missing_lang_label.xlsx rename to onadata/apps/logger/tests/fixtures/childrens_survey_sw_missing_en_label.xlsx diff --git a/onadata/libs/tests/utils/test_export_builder.py b/onadata/libs/tests/utils/test_export_builder.py index b6516d0038..2119672e76 100644 --- a/onadata/libs/tests/utils/test_export_builder.py +++ b/onadata/libs/tests/utils/test_export_builder.py @@ -2050,10 +2050,10 @@ def _test_sav_file(section): section_name = section["name"].replace("/", "_") _test_sav_file(section_name) - def test_export_zipped_zap_missing_lang_label(self): + def test_export_zipped_zap_missing_en_label(self): """Blank language label defaults to label for default language""" survey = create_survey_from_xls( - _logger_fixture_path("childrens_survey_sw_missing_lang_label.xlsx"), + _logger_fixture_path("childrens_survey_sw_missing_en_label.xlsx"), default_name="childrens_survey_sw", ) # default_language is set to swahili @@ -2081,6 +2081,7 @@ def test_export_zipped_zap_missing_lang_label(self): section_name = section["name"] if section_name == "childrens_survey_sw": + # Default swahili label is used incase english label is missing for question result = filter( lambda question: question["label"] == "1. Jina lako ni?", section["elements"], @@ -2089,6 +2090,7 @@ def test_export_zipped_zap_missing_lang_label(self): checks += 1 if section_name == "children": + # Default swahili label is used incase english label is missing for choice result = filter( lambda choice: choice["label"] == "fav_colors/Nyekundu", section["elements"],