Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace load_class #1636

Closed
moshthepitt opened this issue Jun 18, 2019 · 0 comments · Fixed by #1639
Closed

Replace load_class #1636

moshthepitt opened this issue Jun 18, 2019 · 0 comments · Fixed by #1639
Assignees
@peterMuriuki
Labels
Enhancement Good First Issue Has-PR Size: Small (≤1)
Milestone
Week 26 - 27 (2019)

Comments

@moshthepitt
Copy link
Contributor

moshthepitt commented Jun 18, 2019 •
edited by imkingrobi
Loading

Django provides a import_string which does the same thing i.e.

from django.utils.module_loading import import_string

We should deprecate load_class (found in onadata/apps/api/tools.py) and use this instead.

Aha! Link: https://ona.aha.io/features/PROD-238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterMuriuki peterMuriuki

Labels
Enhancement Good First Issue Has-PR Size: Small (≤1)
Projects
None yet
Milestone
Week 26 - 27 (2019)
Development

Successfully merging a pull request may close this issue.

Depracate load_class in favour of Django's import_string onaio/onadata
3 participants
@ukanga @moshthepitt @peterMuriuki