Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track users who delete submissions #1640

Closed
lincmba opened this issue Jun 27, 2019 · 3 comments · Fixed by #1646
Closed

Track users who delete submissions #1640

lincmba opened this issue Jun 27, 2019 · 3 comments · Fixed by #1646

Comments

@lincmba
Copy link
Contributor

lincmba commented Jun 27, 2019

When submissions are deleted, both the timestamp and user who deleted it should be tracked.
Currently, only the timestamp is logged and not the users who did the deletion.

Aha! Link: https://ona.aha.io/features/PROD-235

@shreyanshrs44
Copy link

Hi, I would like to work on this issue . Also this is my first attempt contributing to onadata. Can you tell me from where I should start working on this issue ?

@lincmba
Copy link
Contributor Author

lincmba commented Jun 28, 2019

Hi @shreyanshrs44. Glad to hear that. I will give a few pointers.

First, look at the Instance model, onadata/apps/logger/models/instance.py and how we track the timestamp and user upon deletion.

Then have a look at the view performing the deletion onadata/apps/api/viewsets/data_viewset.py and what's missing.

Don't forget a test.

@shreyanshrs44
Copy link

Thanks for your help. I am working on this issue and trying my best to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants