Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default uuid for the XForm uuid field #1779

Open
DavisRayM opened this issue Feb 7, 2020 · 3 comments
Open

Set a default uuid for the XForm uuid field #1779

DavisRayM opened this issue Feb 7, 2020 · 3 comments

Comments

@DavisRayM
Copy link
Contributor

DavisRayM commented Feb 7, 2020

Feature / Change Request

I think changing the default of the XForm uuid field to uuid.uuid4() from its current default would be a nice Idea.

It would also be nice if this change was implemented with #1773.

Benefits

CC: @ukanga @ivermac @pld @WinnyTroy @lincmba

@pld
Copy link
Member

pld commented Feb 7, 2020

Can you please describe why you think this would be worthwhile?

@DavisRayM
Copy link
Contributor Author

Can you please describe why you think this would be worthwhile?

I think implementing this would remove the worry of the field being an empty string. Which affects a few features the FLOIP endpoint is one feature affected as it utilizes the uuid quite heavily.

This doesn't affect the XForm model in particular as the uuid is usually filled in when one creates the XForm through the viewset / serializer. Any other steps used to create the XForm instance leads to the field being empty unless explicitly passed in.

@pld
Copy link
Member

pld commented Feb 12, 2020

OK cool, I'm not certain, but I'd think things would break with a null UUID, if that's true this is more of an error fix than a feature request. @DavisRayM can you add the Error or Enhancement label based on this.

This sounds worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants