Skip to content

Commit

Permalink
fix(puppets): added error handling for failing chrome kill attempt
Browse files Browse the repository at this point in the history
fix #65
  • Loading branch information
onderceylan committed Nov 1, 2019
1 parent 76aa108 commit 6cc65fd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/helpers/puppets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,11 @@ const generateImages = async (
browser,
);

await browserHelper.killBrowser(browser, chrome).catch();
try {
await browserHelper.killBrowser(browser, chrome);
} catch (e) {
// Silently try killing chrome as Chrome launcher might have already killed it
}

return savedImages;
};
Expand Down

0 comments on commit 6cc65fd

Please sign in to comment.