Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to provide path prefix to generated href links #31

Closed
guidupuy opened this issue Aug 29, 2019 · 2 comments · Fixed by #41
Closed

Add option to provide path prefix to generated href links #31

guidupuy opened this issue Aug 29, 2019 · 2 comments · Fixed by #41
Assignees
Labels
feature request New feature or request help wanted Extra attention is needed released
Milestone

Comments

@guidupuy
Copy link

Would be nice to be able to prepend a path to the href links generated in index.html.

In my case, I'm using pwa-asset-generator in the context of a create-react-app application and my links need to look like this: <link rel="apple-touch-icon" sizes="180x180" href="%PUBLIC_URL%/apple-icon-180.png">

@onderceylan onderceylan added the feature request New feature or request label Aug 29, 2019
@onderceylan
Copy link
Collaborator

Sounds like a handy feature, adding to a milestone.

@onderceylan onderceylan added this to the 1.2.0 milestone Aug 29, 2019
@onderceylan onderceylan added the help wanted Extra attention is needed label Sep 2, 2019
@onderceylan onderceylan self-assigned this Sep 12, 2019
onderceylan pushed a commit that referenced this issue Sep 12, 2019
# [1.2.0](v1.1.7...v1.2.0) (2019-09-12)

### Features

* **main:** added option to provide path prefix to generated href links ([268c671](268c671)), closes [#31](#31)
* **main:** added option to provide path prefix to generated href links ([1e18466](1e18466)), closes [#31](#31)
* **main:** exposed private API via main.js ([afce4af](afce4af)), closes [#5](#5)
* **main:** exposed private API via main.js ([d3367ad](d3367ad)), closes [#5](#5)
* **main:** refactored main and added index.d.ts ([72a7fe4](72a7fe4)), closes [#5](#5)
* **main:** refactored main and added index.d.ts ([1ab1c3e](1ab1c3e)), closes [#5](#5)
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants