Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chrome-launcher to skip chromium download #50

Closed
onderceylan opened this issue Oct 15, 2019 · 2 comments · Fixed by #55
Closed

Use chrome-launcher to skip chromium download #50

onderceylan opened this issue Oct 15, 2019 · 2 comments · Fixed by #55
Assignees
@onderceylan
Labels
feature request New feature or request released

Comments

@onderceylan
Copy link
Collaborator

This feature is for adding support for PUPPETEER_SKIP_CHROMIUM_DOWNLOAD env var, which skips downloading chromium installation on install. When this env var is provided, library should use https://www.npmjs.com/package/chrome-launcher to locate chrome on the system.
@onderceylan onderceylan added the feature request New feature or request label Oct 15, 2019
@onderceylan
Copy link
Collaborator Author

I decided to avoid puppeteer env vars all together, by switching over puppeteer-core from puppeteer dependency. By doing this, the lib will change -install chromium first- approach by doing;

  • Check system for any sort of Chromium instance via chrome-launcher
  • If system Chromium is not found, only then download recommended Chromium revision of puppeteer-core package once

onderceylan added a commit that referenced this issue Oct 21, 2019
@onderceylan
feat(pptr): switched over puppeteer-core to avoid chromium install
11045a1 
Switched over using puppeteer-core to avoid chromium download on every install. With
chrome-launcher, lib will first try to locate any Chromium instance that is installed on users
system, and only if not found, it will installed preferred chromium revision that is declared on
puppeteer-core pkg.

fix #50
onderceylan added a commit that referenced this issue Oct 21, 2019
@onderceylan
fix(browser): added error handling for chrome-launcher
b37d2bb 
Added error handling for chrome-launcher

fix #50
onderceylan added a commit that referenced this issue Oct 24, 2019
@onderceylan
docs(readme): added puppeteer-core feature details to docs
6b70369 
Added puppeteer-core feature details to docs

fix #50
onderceylan added a commit that referenced this issue Oct 24, 2019
@onderceylan
refactor(browser): refactored how browser instances are init and killed
9ffeb4d 
Better handling of initialization and killing of the browsers for both scenarios of using system
browser and package chromium

re #50
@onderceylan onderceylan mentioned this issue Oct 24, 2019
Merged
onderceylan added a commit that referenced this issue Oct 25, 2019
@onderceylan
feat(pptr): switched over puppeteer-core to avoid chromium install
05edb2e 
Switched over using puppeteer-core to avoid chromium download on every install. With
chrome-launcher, lib will first try to locate any Chromium instance that is installed on users
system, and only if not found, it will installed preferred chromium revision that is declared on
puppeteer-core pkg.

fix #50
onderceylan added a commit that referenced this issue Oct 25, 2019
@onderceylan
fix(browser): added error handling for chrome-launcher
c6ed23a 
Added error handling for chrome-launcher

fix #50
onderceylan added a commit that referenced this issue Oct 25, 2019
@onderceylan
docs(readme): added puppeteer-core feature details to docs
398ff01 
Added puppeteer-core feature details to docs

fix #50
onderceylan added a commit that referenced this issue Oct 25, 2019
@onderceylan
refactor(browser): refactored how browser instances are init and killed
936869e 
Better handling of initialization and killing of the browsers for both scenarios of using system
browser and package chromium

re #50
onderceylan pushed a commit that referenced this issue Oct 25, 2019
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
13d8f90 
# [2.0.0](v1.3.1...v2.0.0) (2019-10-25)

### Bug Fixes

* **browser:** added error handling for chrome-launcher ([c6ed23a](c6ed23a)), closes [#50](#50)
* **package:** suppressed security warning by changing pkg v strategy ([9987e39](9987e39)), closes [#53](#53)

### Features

* **file:** avoided saving a shell html file ([b96d545](b96d545)), closes [#52](#52)
* **icon:** added optional favicon generation ([699686a](699686a)), closes [#47](#47)
* **main:** added dark mode support for iOS ([f4aca1c](f4aca1c)), closes [#51](#51)
* **pptr:** switched over puppeteer-core to avoid chromium install ([05edb2e](05edb2e)), closes [#50](#50)
* **pwa:** added single quotes option for generated HTML tags ([351a3cc](351a3cc)), closes [#49](#49)

### BREAKING CHANGES

* **main:** generateImages method from the module API now returns HTMLMeta object with the
chunks of HTML content, instead of one big HTML string
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan onderceylan self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
feature request New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.0.0 release elegantapp/pwa-asset-generator
1 participant
@onderceylan