Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to pass args to puppeteer such as "--disable-dev-shm-usage" ? #517

Closed
CharlesGrimont opened this issue Feb 9, 2021 · 4 comments · Fixed by #633
Closed
Labels
feature request New feature or request released

Comments

@CharlesGrimont
Copy link
Contributor

Hi !

Is it possible to pass args to puppeteer such as "--disable-dev-shm-usage" ?

Thanks

@CharlesGrimont CharlesGrimont added the feature request New feature or request label Feb 9, 2021
@onderceylan
Copy link
Collaborator

Hi @CharlesGrimont, thanks for your feedback. I think this arg can be one of the default args in the library. Let me do some tests on it.

@CharlesGrimont
Copy link
Contributor Author

Hi !

Did you find any time to perform some tests ?

Would you like some help ?

Regards

CharlesGrimont added a commit to convertigo/pwa-asset-generator that referenced this issue Mar 15, 2021
… default one

Running pwa-asset-generator headless in an environment like docker / kubernetes causes a lot of
issues, since we are not able to increase shared memory, we must add puppeteer's
"--disable-dev-shm-usage" arg as a default launch arg

ref elegantapp#517
onderceylan pushed a commit that referenced this issue Jul 13, 2021
… default one

Running pwa-asset-generator headless in an environment like docker / kubernetes causes a lot of
issues, since we are not able to increase shared memory, we must add puppeteer's
"--disable-dev-shm-usage" arg as a default launch arg

ref #517
onderceylan pushed a commit that referenced this issue Jul 13, 2021
…t one

Running pwa-asset-generator headless in an environment like docker / kubernetes causes a lot of
issues, since we are not able to increase shared memory, we must add puppeteer's
"--disable-dev-shm-usage" arg as a default launch arg

ref #517
onderceylan pushed a commit that referenced this issue Jul 13, 2021
…t one

Running pwa-asset-generator headless in an environment like docker / kubernetes causes a lot of
issues, since we are not able to increase shared memory, we must add puppeteer's
"--disable-dev-shm-usage" arg as a default launch arg

ref #517
onderceylan pushed a commit that referenced this issue Jul 13, 2021
# [4.2.0](v4.1.1...v4.2.0) (2021-07-13)

### Features

* **main:** add puppeteer's "--disable-dev-shm-usage" arg as a default one ([bc655fd](bc655fd)), closes [#517](#517)
@onderceylan
Copy link
Collaborator

Hi @CharlesGrimont, this was added on version 4.2.0 and reverted with version 4.2.1 because it created issues for users on linux.

Can you please test your use case with version 4.2.0 and share your findings here?

onderceylan added a commit that referenced this issue Jul 13, 2021
Increase shared memory size of Chromium instance by adding --disable-dev-shm-usage. See
https://developers.google.com/web/tools/puppeteer/troubleshooting#tips for details.

fix #517
onderceylan added a commit that referenced this issue Jul 13, 2021
Increase shared memory size of Chromium instance by adding --disable-dev-shm-usage. See
https://developers.google.com/web/tools/puppeteer/troubleshooting#tips for details.

fix #517
onderceylan pushed a commit that referenced this issue Jul 13, 2021
# [4.3.0](v4.2.1...v4.3.0) (2021-07-13)

### Features

* **main:** add "--disable-dev-shm-usage" as a default chrome launch arg ([a444f76](a444f76)), closes [#517](#517)
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request released
Projects
None yet
2 participants