Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome launcher does not exit properly on connection error #58

Closed
onderceylan opened this issue Oct 28, 2019 · 3 comments · Fixed by #63
Closed

Chrome launcher does not exit properly on connection error #58

onderceylan opened this issue Oct 28, 2019 · 3 comments · Fixed by #63
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@onderceylan
Copy link
Collaborator

onderceylan commented Oct 28, 2019 •
edited
Loading

In case of connect ECONNREFUSED error, chrome launcher instances doesn't get killed. This creates memory issues and introduces SPOF for the lib.

A preferred solution for this is to treat system browser initialization differently and let launcher handle the process management on error.
@onderceylan onderceylan added the bug Something isn't working label Oct 28, 2019
@elmeerr
Copy link

elmeerr commented Oct 30, 2019 •
edited
Loading

Hi...nice CLI man, congrats!!

I'm facing this issue on a windows 10 machine.

Error: connect ECONNREFUSED 127.0.0.1:57911 �
Error: connect ECONNREFUSED 127.0.0.1:57932
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1128:14)
Error: connect ECONNREFUSED 127.0.0.1:57920

Is there a workaround for this?

@onderceylan
Copy link
Collaborator Author

Hi...nice CLI man, congrats!!

I'm facing this issue on a windows 10 machine.

Error: connect ECONNREFUSED 127.0.0.1:57911 �
Error: connect ECONNREFUSED 127.0.0.1:57932
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1128:14)
Error: connect ECONNREFUSED 127.0.0.1:57920

Is there a workaround for this?

Hi @elmeerr, thank you! I think this is a bug introduced with v2. Can you please try installing v1.3.1 - https://www.npmjs.com/package/pwa-asset-generator/v/1.3.1?

I’m working on the fix atm. Sorry for inconvenience.

onderceylan added a commit that referenced this issue Oct 31, 2019
@onderceylan
feat(main): upgraded to pptr v2 and optimized chrome launcher
57e4a87 
Upgraded to pptr v2 to limit number of total running instances to 1. Optimized chrome launcher flags
to fix the connection error issues.

fix #62 fix #58
@onderceylan onderceylan mentioned this issue Oct 31, 2019
Merged
onderceylan added a commit that referenced this issue Oct 31, 2019
@onderceylan
fix(browser): added a method to kill premature chrome instances
2ea19bb 
Added a method to kill premature chrome instances on connection error

fix #58
onderceylan added a commit that referenced this issue Nov 1, 2019
@onderceylan
feat(main): upgraded to pptr v2 and optimized chrome launcher
a14e8e6 
Upgraded to pptr v2 to limit number of total running instances to 1. Optimized chrome launcher flags
to fix the connection error issues.

fix #62 fix #58
onderceylan added a commit that referenced this issue Nov 1, 2019
@onderceylan
fix(browser): added a method to kill premature chrome instances
ad69854 
Added a method to kill premature chrome instances on connection error

fix #58
onderceylan pushed a commit that referenced this issue Nov 1, 2019
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
76aa108 
# [2.1.0](v2.0.2...v2.1.0) (2019-11-01)

### Bug Fixes

* **browser:** added a method to kill premature chrome instances ([ad69854](ad69854)), closes [#58](#58)
* **file:** replaced backslash in path output of generate images API res ([6563977](6563977)), closes [#64](#64)

### Features

* **main:** upgraded to pptr v2 and optimized chrome launcher ([a14e8e6](a14e8e6)), closes [#62](#62) [#58](#58)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan onderceylan self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(main): upgraded to pptr v2 and optimized chrome launcher elegantapp/pwa-asset-generator
2 participants
@onderceylan @elmeerr