Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pptr 2 to and generate images on single chromium instance #62

Closed
onderceylan opened this issue Oct 31, 2019 · 1 comment · Fixed by #63
Closed

Upgrade to pptr 2 to and generate images on single chromium instance #62

onderceylan opened this issue Oct 31, 2019 · 1 comment · Fixed by #63
Assignees
@onderceylan
Labels
feature request New feature or request released

Comments

@onderceylan
Copy link
Collaborator

Before puppeteer v2, we had to initialize a new chromium instance to take a screenshot of a different window size. New schreenshot API can change the viewport properly so we just need to create a new tab, no need to create a new instance.

This change will make the lib much less cpu and memory intensive.
@onderceylan onderceylan added the feature request New feature or request label Oct 31, 2019
@onderceylan onderceylan self-assigned this Oct 31, 2019
onderceylan added a commit that referenced this issue Oct 31, 2019
@onderceylan
feat(main): upgraded to pptr v2 and optimized chrome launcher
57e4a87 
Upgraded to pptr v2 to limit number of total running instances to 1. Optimized chrome launcher flags
to fix the connection error issues.

fix #62 fix #58
@onderceylan onderceylan mentioned this issue Oct 31, 2019
Merged
onderceylan added a commit that referenced this issue Nov 1, 2019
@onderceylan
feat(main): upgraded to pptr v2 and optimized chrome launcher
a14e8e6 
Upgraded to pptr v2 to limit number of total running instances to 1. Optimized chrome launcher flags
to fix the connection error issues.

fix #62 fix #58
onderceylan pushed a commit that referenced this issue Nov 1, 2019
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
76aa108 
# [2.1.0](v2.0.2...v2.1.0) (2019-11-01)

### Bug Fixes

* **browser:** added a method to kill premature chrome instances ([ad69854](ad69854)), closes [#58](#58)
* **file:** replaced backslash in path output of generate images API res ([6563977](6563977)), closes [#64](#64)

### Features

* **main:** upgraded to pptr v2 and optimized chrome launcher ([a14e8e6](a14e8e6)), closes [#62](#62) [#58](#58)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
feature request New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(main): upgraded to pptr v2 and optimized chrome launcher elegantapp/pwa-asset-generator
1 participant
@onderceylan