Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image save path in generateImages API result includes backslash on Windows #64

Closed
onderceylan opened this issue Oct 31, 2019 · 1 comment
Closed

Image save path in generateImages API result includes backslash on Windows #64

onderceylan opened this issue Oct 31, 2019 · 1 comment
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@onderceylan
Copy link
Collaborator

Image save path in generateImages API result includes backslash on Windows. We need to replace backslashes with slashes for the path output.
@onderceylan onderceylan added the bug Something isn't working label Oct 31, 2019
@onderceylan onderceylan self-assigned this Oct 31, 2019
onderceylan added a commit that referenced this issue Oct 31, 2019
@onderceylan
fix(file): replaced backslash in path output of generate images API res
4cf6912 
Image save path in generateImages API result includes backslash on Windows. We need to replace
backslashes with slashes for the path output.

fix #64
onderceylan pushed a commit that referenced this issue Nov 1, 2019
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
76aa108 
# [2.1.0](v2.0.2...v2.1.0) (2019-11-01)

### Bug Fixes

* **browser:** added a method to kill premature chrome instances ([ad69854](ad69854)), closes [#58](#58)
* **file:** replaced backslash in path output of generate images API res ([6563977](6563977)), closes [#64](#64)

### Features

* **main:** upgraded to pptr v2 and optimized chrome launcher ([a14e8e6](a14e8e6)), closes [#62](#62) [#58](#58)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onderceylan