Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent background does not work #68

Closed
elmeerr opened this issue Nov 7, 2019 · 4 comments
Closed

Transparent background does not work #68

elmeerr opened this issue Nov 7, 2019 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation released

Comments

@elmeerr
Copy link

elmeerr commented Nov 7, 2019

Describe the bug
The docs says that transparent background is default but this is not happening

To Reproduce
Steps to reproduce the behavior:

  1. Execute cli command npx pwa-asset-generator https://icon-library.net/images/img_566996.png
  2. Open generated images
  3. See error

Expected behavior
Images with transparent background.

System (please complete the following information):

  • OS: windows 10
  • node version 12.13.0
  • npm version 6.12.0
  • cli version 2.1.1

Screenshots
Webstorm show if the background is transparent (which is not in this case)
image

@elmeerr elmeerr added bug Something isn't working needs verification Bug needs to be verified with reproduction labels Nov 7, 2019
@onderceylan
Copy link
Collaborator

Hi @elmeerr, thanks for the feedback. Although default background color is transparent, there's another option that you need to use which impacts this scenario: opaque.

You need to run your command with --opaque false option in order to get the transparency;
npx pwa-asset-generator https://icon-library.net/images/img_566996.png --opaque false

I understand this might be confusing but it's necessary to use for the background css values with alpha channels.

@onderceylan
Copy link
Collaborator

I'm updating the docs to clarify this btw, thanks for the heads up!

onderceylan added a commit that referenced this issue Nov 8, 2019
Updated docs with examples to clarify transparency option

fix #68
onderceylan pushed a commit that referenced this issue Nov 8, 2019
## [2.1.2](v2.1.1...v2.1.2) (2019-11-08)

### Bug Fixes

* **cli:** updated docs to clarify transparency option ([a4bcaff](a4bcaff)), closes [#68](#68)
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@elmeerr
Copy link
Author

elmeerr commented Nov 9, 2019

@onderceylan Thanks for clarifying this!

@onderceylan onderceylan added documentation Improvements or additions to documentation and removed bug Something isn't working needs verification Bug needs to be verified with reproduction labels Nov 10, 2019
@onderceylan onderceylan self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

No branches or pull requests

2 participants