Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get more than 3 rows in Waterfox G5.1 #189

Open
Tampa opened this issue Nov 29, 2022 · 5 comments
Open

Can't get more than 3 rows in Waterfox G5.1 #189

Tampa opened this issue Nov 29, 2022 · 5 comments

Comments

@Tampa
Copy link

Tampa commented Nov 29, 2022

I normally use 7 rows of tabs, but with Waterfox G5.1 it only ever shows 3 rows. I can set any number from 2-99 and it remains at 3 rows. This has been the case with older versions of TMP and Waterfox as well, not a new problem. Anything I can check to see why this might be or is 3 rows the maximum now?

@onemen
Copy link
Owner

onemen commented Nov 29, 2022

@black7375,
can you check if this issue is related to #168 ?

@Tampa
Copy link
Author

Tampa commented Nov 29, 2022

I did set userChrome.theme.enable to false, no change. If you need more debugging information let me know :)

@onemen
Copy link
Owner

onemen commented Nov 29, 2022

@Tampa, make sure you are using the latest version

I've found some issue with the calculation of multi-row height but it does not explain why you only see 3 rows

  • report if you see any message in the browser console when you change the number of rows.

Regarding the issue that i've found:
Tab mix calculate max-height for the tab bar based on
css variables --tab-min-height + 2 * --tab-block-margin

The default value for --tab-min-height is 36px and for this case there is no problem, however if the user reduce this value manually or by using browser.uidensity preference, there is an if the new value is less then 32.4px

Waterfox set the inner height of the tab tab-label-container to be 2.7em that is 2.7x12px

#tabbrowser-tabs:not([secondarytext-unsupported]) .tab-label-container {
  height: 2.7em;
}

The result is that Tab Mix based its calculation on the wrong height

@Tampa
Copy link
Author

Tampa commented Nov 29, 2022

Have not changed the tab height at all, just the width. I don't see options for that anymore either, exporting the preferences the only style changes are the font and color.

Browser console on options open reports:

17:51:30.570 Applying chrome://tabmixplus/content/preferences/appearance.xhtml to chrome://tabmixplus/content/preferences/preferences.xhtml Overlays.jsm:90:15
17:51:30.572 Loading script chrome://tabmixplus/content/preferences/appearance.js into chrome://tabmixplus/content/preferences/preferences.xhtml Overlays.jsm:537:15
17:51:30.667 Uncaught (in promise) undefined

Changing and applying the row count writes no messages to console.

I tried switching the themes, disabling the dark theme, but that did nothing.

Maybe I just have to do a refresh or reinstall at this point. I have been upgrading the extension ever since the first pre-release so maybe something broke along the way.

@Tampa
Copy link
Author

Tampa commented Nov 29, 2022

Refreshing and reinstalling did help, I have 7 rows now. I guess the settings were bad. Now I only have to fix the large empty square on the right and it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants