[Lint] Double force casting

[jacob-tucker]

Current Behavior

Right now if you double force cast, for example, test["testing"]!!, the linter will tell you that you are performing an unecessary force unwrap.

However, given the fact that it's possible for dictionaries to have nil values, this actually may be needed some times to convert, for example, a String?? to a String

Expected Behavior

The linter should not complain about a double force cast if the type is a double optional

Steps To Reproduce

pub fun main(): AnyStruct {
  let bin: {String: String} = { "gg": "10" }
  var v : {String: AnyStruct} =  { "deniz": bin["gg"] }
  let thing = v["deniz"]!!.getType()
  return thing
}

Environment

- Cadence version: 0.40.0
- Network: Emulator (or any)

[turbolent]

Doesn't this work as expected:

• The value type of v is AnyStruct
• v["deniz"] results in AnyStruct?
• Two force-unwraps are used, but only one is necessary to unwrap

[bluesign]

I think problem is: AnyStruct covering optional types. This is working as intended ( warning ) for sure.

But I think this should be only allowed to written as :

pub fun main(): AnyStruct {
  let bin: {String: String} = { "gg": "10" }
  var v : {String: AnyStruct?} =  { "deniz": bin["gg"] }
  let thing = v["deniz"]!!.getType()
  return thing
}

But as AnyStruct covers AnyStruct? this is going into area of cannot be statically determined.

[turbolent]

Yeah, that's what I tried to point out: The analysis works only on static types, and from that perspective the implementation is correct.

However, you're right that AnyStruct as the top-type covers any other dynamic type, so the dynamic type of the underlying value could actually be optional. This is unlike any other type (e.g. think through the example with the dictionary's value type being e.g. Int).

So the analysis could be improved here to ignore Any/AnyStruct/AnyResouce, to avoid reporting a warning that the operator is unnecessary, where it might actually be necessary. 👍

[turbolent]

In particular, the exception should be added here:

cadence-tools/lint/unnecessary_force_analyzer.go

Lines 59 to 60 in 55644ee

	_, ok = valueType.(*sema.OptionalType)
	if !ok {