Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for child container being mutated while parent container is iterated #2663

Closed
fxamacker opened this issue Jul 18, 2023 · 0 comments · Fixed by #2733
Closed

Add tests for child container being mutated while parent container is iterated #2663

fxamacker opened this issue Jul 18, 2023 · 0 comments · Fixed by #2733
Assignees
@SupunS
Labels
Feedback Needs Test Cases

Comments

@fxamacker
Copy link
Member

fxamacker commented Jul 18, 2023 •
edited
Loading

It would be good to have this for onflow/atree#292.

Issue to be solved

Currently, child containers are allowed to be mutated while their parent container is iterated. However, there does not appear to be any tests for this.

Suggested Solution

Add tests for child container being mutated while parent container is iterated.

Alternatively, determine if it is feasible to not allow child containers being mutated while parent container is iterated.

For more details, see Discord thread.
@fxamacker fxamacker changed the title Add tests for child container being mutated while parent container is iterated Add tests (or don't allow) child container being mutated while parent container is iterated Jul 18, 2023
@fxamacker fxamacker changed the title Add tests (or don't allow) child container being mutated while parent container is iterated Add tests for child container being mutated while parent container is iterated Jul 19, 2023
@SupunS SupunS mentioned this issue Aug 17, 2023
Merged
6 tasks
@SupunS SupunS self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SupunS SupunS

Labels
Feedback Needs Test Cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for inner container mutation while iterating outer onflow/cadence
3 participants
@turbolent @SupunS @fxamacker