Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not required param shop-id for ongr:sync:storage:create #116

Closed
GrandLTU opened this issue Jan 27, 2015 · 5 comments · Fixed by #164
Closed

Not required param shop-id for ongr:sync:storage:create #116

GrandLTU opened this issue Jan 27, 2015 · 5 comments · Fixed by #164

Comments

@GrandLTU
Copy link
Contributor

ongr:sync:storage:create asks for shop id but there are configuration available for all present shops
and tables for all shops should be present for ongr:sync:provide command.

So i suggest removing --shop-id=... and make command to create tables for all shops.

@trylika
Copy link
Contributor

trylika commented Jan 27, 2015

--shop-id=... is optional, so there is no issue in here, also might be related to #102

@trylika trylika added the ready label Jan 28, 2015
@gyKa
Copy link
Contributor

gyKa commented Feb 3, 2015

Is this issue still relevant?

@GrandLTU
Copy link
Contributor Author

I believe yes, when sync storage is used storages for all configured shops are required.
Maybe make that when no --shop-id=... is provided command creates storages for all configured shops.

@tautrimas
Copy link
Contributor

I agree with @GrandLTU. All storages should be configured if no --shop-id is used.

@tautrimas
Copy link
Contributor

After consulting with @GrandLTU, suggestion is to

  1. validate --shop-id so that it is a valid shop id.
  2. if value is not given, first shop id should be used (in case it is non-multi-shop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants