Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity\SyncJobs should be removed #128

Closed
trylika opened this issue Jan 29, 2015 · 3 comments · Fixed by #135
Closed

Entity\SyncJobs should be removed #128

trylika opened this issue Jan 29, 2015 · 3 comments · Fixed by #135

Comments

@trylika
Copy link
Contributor

trylika commented Jan 29, 2015

It appears that the whole Enityt\SyncJobs class is not used, except for static constants.
This should be re-factored, and useless entity removed.

https://github.com/ongr-io/ConnectionsBundle/blob/master/Entity/SyncJob.php
@trylika trylika added the steady label Jan 29, 2015
@trylika trylika mentioned this issue Jan 29, 2015
Merged
@gyKa gyKa self-assigned this Jan 30, 2015
@gyKa gyKa added go and removed steady labels Jan 30, 2015
@gyKa
Copy link
Contributor

gyKa commented Jan 30, 2015

Sync\DiffProvider\SyncJobs\JobManager uses it.

@trylika
Copy link
Contributor Author

trylika commented Jan 30, 2015

@gyKa yes it is, but jobmanager will be removed in #115, since it's not used, thus making this class absolutelly useless.

@gyKa
Copy link
Contributor

gyKa commented Jan 30, 2015

👍 😉

@gyKa gyKa mentioned this issue Jan 30, 2015
Merged
@gyKa gyKa added qa and removed go labels Jan 30, 2015
@trylika trylika removed the qa label Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Entity\SyncJobs and refactor code.
2 participants
@gyKa @trylika