Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractImportModifyEventListener should log ERROR #160

Closed
tautrimas opened this issue Feb 20, 2015 · 3 comments · Fixed by #163
Closed

AbstractImportModifyEventListener should log ERROR #160

tautrimas opened this issue Feb 20, 2015 · 3 comments · Fixed by #163

Comments

@tautrimas
Copy link
Contributor

Should AbstractImportModifyEventListener.php#L48 log NOTICE or ERROR? This is an error and action should be taken to fix such inconsistencies. @saimaz, @mindaugasbarysas?
@mindaugasbarysas
Copy link
Contributor

I aggree completely with @tautrimas. This should be an error.

@tautrimas
Copy link
Contributor Author

  • Please check that there are no more NOTICE logging in such situations in other places in Connections.

@saimaz
Copy link
Contributor

saimaz commented Feb 20, 2015

Yes, this definitely must be an error.

@GrandLTU GrandLTU self-assigned this Feb 23, 2015
@GrandLTU GrandLTU mentioned this issue Feb 23, 2015
Merged
@GrandLTU GrandLTU added qa and removed in progress labels Feb 23, 2015
@lmikelionis lmikelionis removed the qa label Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change log level for inconsistencies. GrandLTU/ConnectionsBundle
5 participants
@saimaz @tautrimas @lmikelionis @GrandLTU @mindaugasbarysas