Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[binlog] Refactor binlog parsing by removing decorator pattern #75

Open
tautrimas opened this issue Dec 30, 2014 · 1 comment
Open

[binlog] Refactor binlog parsing by removing decorator pattern #75

tautrimas opened this issue Dec 30, 2014 · 1 comment

Comments

@tautrimas
Copy link
Contributor

Currently, BinLog parser is using decorator pattern with nested iterators.

Team pointed out, that this is a hacky solution and should be resolved by using more flat composition architecture.
@trylika
Copy link
Contributor

trylika commented Jan 5, 2015

For parsing bin log in blocks, this regexp could be used:

/^#([0-9\s:]*)\s.*?\send_log_pos\s([0-9]*)\s(?:.|\n)*?^# at \2$/gm

@trylika trylika added the ready label Jan 28, 2015
@tfe2012 tfe2012 added in progress and removed ready labels Mar 10, 2015
@tfe2012 tfe2012 self-assigned this Mar 10, 2015
@tfe2012 tfe2012 removed their assignment Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tautrimas @trylika @tfe2012