Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple shop id functionality. #101

Merged
merged 3 commits into from
Jan 19, 2015
Merged

Fix multiple shop id functionality. #101

merged 3 commits into from
Jan 19, 2015

Conversation

gyKa
Copy link
Contributor

@gyKa gyKa commented Jan 19, 2015

Related to #88

@gyKa gyKa added the qa label Jan 19, 2015
/**
* Common actions required for all extractors.
*/
class AbstractExtractor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's abstract why class is not abstract?

}

/**
* Test if extract is able to add data to the storage for item update action.
*/
public function testExtractForUpdateItem()
public function ttestExtractForUpdateItem()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ttest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

GrandLTU added a commit that referenced this pull request Jan 19, 2015
Fix multiple shop id functionality.
@GrandLTU GrandLTU merged commit 938dcb4 into ongr-archive:master Jan 19, 2015
@GrandLTU GrandLTU removed the qa label Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants