Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGF, excessive use of ( new variation token #2005

Open
rooklift opened this issue Sep 19, 2022 · 2 comments
Open

SGF, excessive use of ( new variation token #2005

rooklift opened this issue Sep 19, 2022 · 2 comments

Comments

@rooklift
Copy link

rooklift commented Sep 19, 2022

Currently, when I download an SGF file of a game from OGS, every single move is preceeded by the "new subtree" token, that being (

While this is probably not illegal, it is very odd and unnecessary.

Typically one only writes ( when there are 2 or more descendants of the current node (i.e. when there's both the main move and some variations).

@benjaminpjones
Copy link
Contributor

Haha yeah I've noticed this too. Given that moves are usually 6 characters: (e.g. ;W[aa]), a pair of parentheses on every move adds 33% to the moves portion of the file in the worst case!

@loarabia
Copy link

Im curious about this also. It came up in a comment to a PR I made SabakiHQ/sgf#16. Since I had just grabbed a game as a test case I couldn’t really answer the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants