Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flatbuffers>=2.0 #1977

Closed
stancld opened this issue Jun 23, 2022 · 4 comments · Fixed by #2050
Closed

Add support for flatbuffers>=2.0 #1977

stancld opened this issue Jun 23, 2022 · 4 comments · Fixed by #2050
Labels
bug An unexpected problem or unintended behavior

Comments

@stancld
Copy link

stancld commented Jun 23, 2022

Hello all 👋

First of all, I'd like to thank you for this great repo and package!

I would like to ask you if there's any plan to add support for flatbuffers>=2.0 in a perceivable future? :] Also, if interested, I'm definitely willing to give a try to handle these breaking changes and try to accommodate supports for both versions (It looks like there are some breaking changes between versions 1.12 and 2.0).

@stancld stancld changed the title Add a support for flatbuffers>=2.0 Add support for flatbuffers>=2.0 Jun 23, 2022
@stancld stancld closed this as completed Jun 23, 2022
@stancld
Copy link
Author

stancld commented Jun 23, 2022

Oh, sorry for the false alarm. It's rather an issue of TF itself. :]

@janbernloehr
Copy link
Contributor

tf 2.10 switched to flatbuffers 2.0 so we should reopen this

@benquan
Copy link

benquan commented Sep 28, 2022

When installing:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorflow 2.10.0 requires flatbuffers>=2.0, but you have flatbuffers 1.12 which is incompatible.

@stancld
Copy link
Author

stancld commented Nov 6, 2022

@fatcat-z Thanks a lot for the fix! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants