Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo Proposal for Doctest #141

Closed
area55git opened this issue Aug 8, 2018 · 20 comments
Closed

Logo Proposal for Doctest #141

area55git opened this issue Aug 8, 2018 · 20 comments

Comments

@area55git
Copy link
Contributor

Hi, In response to your request for Logo, I am very grateful to be able to collaborate in your project.

I need a short review about Doctest to start with the sketches. I can improve the existing one or create something totally new and different. You can tell me your suggestions.

@onqtam
Copy link
Member

onqtam commented Aug 8, 2018

well here are some ideas:

  • doctest is about testing - reliability, safety net, comfort, a green light that everything is ok after refactoring (changing code)
  • doctest is the lightest testing framework for C++ so perhaps something resembling speed or lightness - as a feather or a cheetah (or anything better that comes to your mind)
  • doctest is transparent and light - so you don't notice it - perhaps as a transparent layer on top of the production code (or depicted as a guardian angel)
  • doctest is about mixing the actual production code with the tests themselves - so some mixture (like spices in a stew), or the Yin and yang
  • "production code" could be depicted by some mechanical product like a steam engine? I don't know...
  • doctest is very easy to get started with and use - so simplicity is also a theme

Where do you think the logo should go - at the top of the main readme?

about the size: perhaps a multiple of 888 px? that's the max width of the rendered readme's in github. Or if it is a vector image that shouldn't matter.

Thanks a lot for offering to do this!

@area55git
Copy link
Contributor Author

@onqtam I'm going to work on the sketches, I think I have them ready in 2 days.

@area55git
Copy link
Contributor Author

@onqtam I made an improvement of the existing logo, I will continue working on other proposals, I send this first. On Monday I will send more sketches.

logo proposal for doctest

@area55git
Copy link
Contributor Author

I really like this proposal!

@area55git
Copy link
Contributor Author

In the next one I am working with the image of a hummingbird, because it represents speed and lightness !. I just sent you an immense unfinished so you can tell me your point of view.

logo proposal for doctest 1

@onqtam
Copy link
Member

onqtam commented Aug 15, 2018

Sorry for the late reply!

From the first batch I like the one in the blue rectangle the most. I also like the idea with the hummingbird even more, but I initially mistook the blue version of it for water/waves/sea creature - and only later did I notice that it was a bird.

Perhaps I would need a bit more time to choose. Could the version with the hummingbird be tweaked somehow not to be confused with anything water-related?

And how would you like to proceed with the addition of the logo in the project and you being credited for it? Perhaps with a note in the main readme.md of the repository + credits in the commit message when the logo is introduced? I'll soon be releasing version 2.0 which will be a major update so having a logo would kick ass! :D

@area55git
Copy link
Contributor Author

If you like the idea of the hummingbird I will continue working in that direction. Soon I will present you other sketches.

@area55git
Copy link
Contributor Author

@onqtam what do you think of these options?

logo proposal for doctest

@onqtam
Copy link
Member

onqtam commented Aug 16, 2018

I think I like the most the one with the blue background from the first batch, and also something like this:

my_ver

or this (mostly this):

my_ver_2

So perhaps you could make a PR with all 3 options in some vector file in the /scripts/data folder of the repo and I shall make a final choice in the coming days...? I will attribute you the same way as discussed in the thread about dynamix.

@area55git
Copy link
Contributor Author

Hi @onqtam

logo proposal for doctest

@area55git
Copy link
Contributor Author

Icon or Favicon

logo proposal for doctest 1

@onqtam
Copy link
Member

onqtam commented Aug 19, 2018

Sorry for the late response - finally I choose the second option from the second batch - the one with the blue frame and the bird in the middle (I tested it how it looked in the repository page). I also choose the second from the 3 options of the favicons since it matches the logo the most.

Can you make a PR (against the dev branch) and upload it as a .svg file (in the /scripts/data/ folder) so that I display it vectorized in the main readme?

Thanks for the great work! I will credit you the same way as dynamix

@area55git
Copy link
Contributor Author

File Download HERE

derechos
This work is licensed under a Creative Commons Attribution 4.0 International License.

@area55git
Copy link
Contributor Author

I have 2 options for the Readme folder

readme 1
readme 1 b

Which one do you choose? To do the PR

@onqtam
Copy link
Member

onqtam commented Aug 22, 2018

The first one looked better in the white readme when I tested.

@area55git
Copy link
Contributor Author

I'm gonna put this one at the end

readme 2

@onqtam
Copy link
Member

onqtam commented Aug 22, 2018

Ok, cool! I’ll be infront of a computer in a few hours and ill be able to merge it

@area55git
Copy link
Contributor Author

PR #145
I had a lot of fun with this job, it's very easy to work with you. Thank you for allowing me to collaborate!

lele 4 peq

@onqtam
Copy link
Member

onqtam commented Aug 23, 2018

Thanks a ton for the logo - I love it! Was easy working with you too. The logo is in the dev branch and I expect to publish the 2.0 version today in the master branch. I decided to use the .svg files directly - check it out here:

https://github.com/onqtam/doctest/tree/dev

and the credits at the bottom:

https://github.com/onqtam/doctest/tree/dev#logo

@onqtam
Copy link
Member

onqtam commented Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants