MSVC warnings: narrowing conversion, signed/unsigned mismatch

[nickhutchinson]

Description

The following in doctest.cpp can cause MSVC to raise C4245 (signed/unsigned mismatch) and C4838 (narrowing conversion). This is because EXCEPTION_ILLEGAL_INSTRUCTION and friends may be defined as either a DWORD (unsigned long) or NTSTATUS (signed long) depending on whether ntstatus.h is included.

Simplest solution would be to static_cast to DWORD.

    struct SignalDefs
    {
        DWORD id;
        const char* name;
    };
    // ...
    SignalDefs signalDefs[] = {
            {EXCEPTION_ILLEGAL_INSTRUCTION, "SIGILL - Illegal instruction signal"},
            {EXCEPTION_STACK_OVERFLOW, "SIGSEGV - Stack overflow"},
            {EXCEPTION_ACCESS_VIOLATION, "SIGSEGV - Segmentation violation signal"},
            {EXCEPTION_INT_DIVIDE_BY_ZERO, "Divide by zero error"},
    };

// winnt.h (included by windows.h)
#define STATUS_ILLEGAL_INSTRUCTION ((DWORD)0xC000001DL)

// ntstatus.h
#define STATUS_ILLEGAL_INSTRUCTION ((NTSTATUS)0xC000001DL)  

// minwinbase.h (included by windows.h)
#define EXCEPTION_ILLEGAL_INSTRUCTION STATUS_ILLEGAL_INSTRUCTION

Steps to reproduce

#define WIN32_NO_STATUS // suppress macro redefinition warnings
#include <windows.h>
#undef WIN32_NO_STATUS
#include <ntstatus.h>

#include <doctest.h>

Extra information

• doctest version: v2.4.1
• Operating System: Windows
• Compiler+version: MSVC 19.28, Windows SDK 10.0.19041.0

[onqtam]

Thanks for reporting! I just merged the PR - closing this now. Will release an official version..."soon"!