Remove clang-tidy warnings for static fields created by doctest #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings - fuchsia-statically-constructed-objects - cert-err58-cpp are disabled for the creation of static fields within the DOCTEST_GLOBAL_NO_WARNINGS macro. This removes these clang-tidy warnings in user written unit tests at invocation of the TEST_SUITE and related macros.
|
A comment for suppression at the end of a macro works when the macro is expanded elsewhere through a few macro indirections? Nice! Thanks for the PR! I'll probably get to publishing version 2.0.2 (so this will go from the dev branch into master) in a few weeks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When writing unit tests with doctest, clang-tidy raises a warning at each invocation of the
TEST_CASE()orSCENARIO()macro, explicitlyfuchsia-statically-constructed-objectsandcert-err58-cppfor my current version of clang-tidy. The root cause is the intended creation of static variables by the framework. As these warnings are not a consequence of the user written code and there are plenty of them for a big test suite, they should be disabled.This pull request adds an explicit suppression for these two tests at the responsible line in the implementation.
GitHub Issues
The warning
cert-err58-cppwas already discussed in issue #115. The solution provided there however requires some action by the user.