Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify the doctest_with_main C++ standard in CMake. #231

Merged
merged 1 commit into from
May 4, 2019
Merged

Explicitly specify the doctest_with_main C++ standard in CMake. #231

merged 1 commit into from
May 4, 2019

Conversation

DaanDeMeyer
Copy link
Contributor

This fixes compilation issues on older compilers that don't default to
C++11 yet.

This fixes compilation issues on older compilers that don't default to
C++11 yet.
@onqtam
Copy link
Member

onqtam commented May 1, 2019

This could even be applied to the interface doctest target as well since people might "link" to it and complain that their code doesn't compile - I've had that already as a complaint

@DaanDeMeyer
Copy link
Contributor Author

I don't think it will work on the interface target since the properties will only be defined on the target itself and not propagate to its dependents. To specify it on the interface target, I think we'll need target_compile_features(doctest INTERFACE cxx_std_11) but this requires CMake 3.8.

@onqtam onqtam merged commit 25392da into doctest:dev May 4, 2019
@onqtam
Copy link
Member

onqtam commented May 4, 2019

Thanks! and sorry for the late merge :)

onqtam pushed a commit that referenced this pull request May 6, 2019
This fixes compilation issues on older compilers that don't default to
C++11 yet.
onqtam pushed a commit that referenced this pull request Aug 11, 2019
onqtam pushed a commit that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants