Port Catch2 break into debugger for Linux. closes #411 #412
Conversation
|
Sorry for the delay. This is a welcome addition! However I had some problems recently with code being taken as-is from Catch2 and although I do acknowledge at the top of the doctest header that the breaking into the debugger is taken from Catch and even though Catch is BSL-licensed which is MIT-compatible based on my reading, this might need to be changed a bit. IMHO there shouldn't be a problem taking this directly (how is someone else expected to implement it - differently?...), but I'll fix it up after merging (remove the comments, etc) and point to Catch2 for the explanation. |
No problem, thanks for spending time on maintenance! Thank you for being thorough with the licensing, and sorry if it's causing headaches. (I hope I was clear enough that this came mostly verbatim from Catch2. In retrospect I should have linked the relevant sections explicitly.) Very interesting to see the additional discussion context on licensing. Anyway, thanks again for your time and the library! I'm excited to have this feature upstream. |
Description
This adds support for breaking into the debugger on Linux. The code is ported over from Catch2. (I assume that isn't an issue.)
GitHub Issues
#411
Note that I did not run clang-format because it picked up a bunch of other things, and I felt it would muddy the diff.